Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved asset.pipeline.utils.net.Urls + code & config cleanup #44

Merged
merged 6 commits into from Oct 4, 2015
Merged

Improved asset.pipeline.utils.net.Urls + code & config cleanup #44

merged 6 commits into from Oct 4, 2015

Commits on Oct 4, 2015

  1. build.gradle files standardization: 

    spacing
tabs
parentheses
quotes
    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    87e96da View commit details
    Browse the repository at this point in the history

  2. improved asset.pipeline.utils.net.Urls: 

    changed from groovy to java

improved javadocs

added static methods:
concatenateUrl(...)
getDefaultPort(String)
getUrlSansScheme(String)
hasAuthority(String)
withScheme(*)

added constant Patterns:
HAS_AUTHORITY_URL_PATTERN
URL_COMPONENT_PATTERN

reuse URL_SCHEME_SANS_COLON_REGEX for Patterns, which uses possessive regex for performance

use tabs
    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    a2869b7 View commit details
    Browse the repository at this point in the history

  3. Urls.DEFAULT_PORT_BY_SCHEME is now a ConcurrentHashMap instead of a H… 

    …ashMap
    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    a2069a6 View commit details
    Browse the repository at this point in the history

  4. simplified Urls.append(...) helper methods

    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    77fdc73 View commit details
    Browse the repository at this point in the history

  5. Urls.concatenateUrl(...) now creates a StringBuilder of an appropriat… 

    …e length
    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    ef4f8c3 View commit details
    Browse the repository at this point in the history

  6. added missing Apache 2.0 licenses

    @rgoldberg
    rgoldberg committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    109b09e View commit details
    Browse the repository at this point in the history