Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'mariadb_service' from vars/ to defaults/. #15

Closed
moenka opened this issue Feb 6, 2018 · 3 comments
Closed

Move 'mariadb_service' from vars/ to defaults/. #15

moenka opened this issue Feb 6, 2018 · 3 comments

Comments

@moenka
Copy link

moenka commented Feb 6, 2018

Hi,
I like your role as it helps setting up MariaDB very easily on RedHad distributions. There is but one big issue with MariaDB 5.5 (which can be easily installed with this role).
On CentOS the service for MariaDB 5.5 is called mysql not mariadb.
Unfortunately the mariadb_service is located with the vars/ directory which makes it unchangeable/unconfigurable. This causes the role to fail for MariaDB <10.
I'd like to suggest moving this variable into the defaults/ directory so one has the chance to overwrite this variable.

This would be the fast solution. The better solution would be to check on the mariadb_version variable and change the mariadb_service variable to mysql if the version is lower then 10 on a CentOS distribution.

@moenka
Copy link
Author

moenka commented Feb 6, 2018

I just saw that the handlers.yml also needs an update on the restart mariadb task where the name attribute has to be catched from the mariadb_service variable.
This is not super urgent so I try to provide a pull request on this.

@bertvv
Copy link
Owner

bertvv commented Aug 29, 2018

Fixed in a18f0dc and v2.1.0, just released!
Sorry it took so long! It was a simple enough fix...

@bertvv bertvv closed this as completed Aug 29, 2018
@moenka
Copy link
Author

moenka commented Aug 31, 2018

Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants