Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick links to PR #191

Closed
moul opened this issue May 6, 2020 · 5 comments · Fixed by #194
Closed

Quick links to PR #191

moul opened this issue May 6, 2020 · 5 comments · Fixed by #194
Assignees
@ekelen
Labels
front pr-merged released

Comments

@moul
Copy link
Member

moul commented May 6, 2020

manfreds-imac - Screen Shot 2020-05-06 at 22 09 16

  • branch=="master":
    • before: <white>Master 1914</white>
    • after: <white>Master</white> <gray>Merge <a href="https://github.com/berty/berty/pull/1914">#1914</a></gray>
  • pull requests:
    • before: <white>Pull 1922</white> <gray>WIP - Switch to real protocol</gray>
    • after: <white>Pull <a href="https://github.com/berty/berty/pull/1922">#1922</a></white> <gray>WIP - Switch to real protocol</gray>
@moul moul added the front label May 6, 2020
@moul
Copy link
Member Author

moul commented May 6, 2020

oh and by the way, it should be 1926, not 1914 in the title for the first entry of the screenshot

@ekelen ekelen mentioned this issue May 7, 2020
Closed
@ekelen
Copy link
Collaborator

ekelen commented May 7, 2020

oh and by the way, it should be 1926, not 1914 in the title for the first entry of the screenshot

Made an issue to add to API #192, let me know how you want to handle it

@ekelen ekelen mentioned this issue May 7, 2020
Closed
@ekelen
Copy link
Collaborator

ekelen commented May 7, 2020

Same issue with getting PR URL with branch master; issue here: #193

@moul
Copy link
Member Author

moul commented May 7, 2020

I added the same comment on the two issues

@ekelen ekelen mentioned this issue May 7, 2020
Merged
@helpr helpr bot added the pr-available label May 7, 2020
@helpr helpr bot added pr-merged and removed pr-available labels May 8, 2020
@github-actions
Copy link

github-actions bot commented May 8, 2020

🎉 This issue has been resolved in version 2.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ekelen ekelen mentioned this issue Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekelen ekelen

Labels
front pr-merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(web): format card titles with PR links berty/yolo
2 participants
@moul @ekelen