MCS Mutex comment + bug fix #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichmond
reviewed
Sep 17, 2021
Comment on lines
+77
to
78
| fence // fence to implement release semantics | ||
| beqz t0, bsg_mcs_mutex_release_no_successor // branch if no successor |
There was a problem hiding this comment.
I'm a little surprised we didn't catch this earlier
drichmond
reviewed
Sep 17, 2021
| /* */ | ||
| /* Additionally, we found the performance of the MCS mutex was little impacted by the number of cores. */ | ||
| /* */ | ||
| /* For the case where there is very low contention on the lock (i.e. maybe only on thread ever needs to acquire), */ |
drichmond
approved these changes
Sep 17, 2021
dpetrisko
pushed a commit
that referenced
this pull request
Sep 27, 2021
* comment summarizing results * typo fix
dpetrisko
pushed a commit
that referenced
this pull request
Sep 29, 2021
* comment summarizing results * typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.