New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NW.js to 0.54.0. #2507
Updated NW.js to 0.54.0. #2507
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mikeller tested here on Windows10 but some weird is happens with report dialog size: |
Maybe we just need a small css fix on dialog "height" value to "fit-content"??not sure how this chrome update is afecting to other things. |
Same on Linux. Otherwise most things so far tested seem to just work. Adding following snippet at line 2291 in main.css would fix it:
Or even better change line 1484 from
There could be more dialogs hidden so far needing this fix. |
@asizon how do you prefer to fix this? Already suggested two ways, as you showed another fix? Want to create a PR to fix this issue so this PR can go forward. |
I have share this issue with @McGiverGim lets see what is happens here. |
I prefer to fix it here, in the PR, but if mikeller can't do it now and you have a PR ready with the fix, I don't see a problem to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so LGTM, @haslinghuis then lets aply height: fit-content in the .dialog class in next PR
AUTOMERGE: (PASS)
|
To go with betaflight/blackbox-log-viewer#518.