Skip to content

Fix css height after update NWjs to 0.54 #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix css height after update NWjs to 0.54 #2516

merged 1 commit into from
Jun 25, 2021

Conversation

@haslinghuis
Copy link
Member

To go with #2507 to fix dialog height

@haslinghuis haslinghuis self-assigned this Jun 20, 2021
@haslinghuis haslinghuis added this to the 10.8.0 milestone Jun 20, 2021
asizon
asizon requested changes Jun 20, 2021
View reviewed changes
@asizon asizon added the Tested label Jun 20, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Jun 25, 2021

AUTOMERGE: (PASS)

  • Github identifies PR as mergeable -> PASS
  • Assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • 'Don't merge' label NOT found -> PASS
  • At least one 'RN:' label found -> PASS
  • 'Tested' label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit a50325b into betaflight:master Jun 25, 2021
@haslinghuis haslinghuis deleted the fix_css_height branch June 25, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@haslinghuis @blckmn @McGiverGim @limonspb @asizon