Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend save and restore for all settings (pid-tuning) #2633

Merged
merged 2 commits into from Oct 14, 2021
Merged

Extend save and restore for all settings (pid-tuning) #2633

merged 2 commits into from Oct 14, 2021

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 11, 2021 •
edited

This PR extends save and restore for all settings.
Second commit fixes dynamic D in RP mode. Thanks to @sugaarK for testing and reporting.

@haslinghuis haslinghuis added this to the 10.8.0 milestone Oct 11, 2021
@haslinghuis haslinghuis self-assigned this Oct 11, 2021
@haslinghuis haslinghuis changed the title Extend save and restore for all settings Extend save and restore for all settings (pid-tuning) Oct 11, 2021
@haslinghuis haslinghuis force-pushed the fix_save_restore branch 3 times, most recently from af91998 to 2bc29a2 Compare October 11, 2021 23:35
@ctzsnooze
Copy link
Member

ctzsnooze commented Oct 12, 2021 •
edited

Tested - this is great!

Now the behaviour of the Reset Current PID Profile Settings button is consistent with other changes made in the PID Tuning tab = unless the resulting changes are explicitly saved by the user, they can be reverted with the Refresh button.

Thanks so much!

ctzsnooze
ctzsnooze previously approved these changes Oct 12, 2021
View reviewed changes
@haslinghuis
Extend save and restore for all settings
3ebd169 
Fix Enable PID sliders button

Fix duplicate block?
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sugaarK
Copy link
Member

sugaarK commented Oct 14, 2021

Awesome @haslinghuis this should be the last fix for the sliders.. I’d review it but I have no privileges 😀

@blckmn
Copy link
Member

blckmn commented Oct 14, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 2dca1e7 into betaflight:master Oct 14, 2021
@haslinghuis haslinghuis deleted the fix_save_restore branch October 14, 2021 22:35
@haslinghuis haslinghuis mentioned this pull request Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX RN: IMPROVEMENT Tested
Projects
None yet
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@haslinghuis @ctzsnooze @sugaarK @blckmn @limonspb @asizon