Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab switching #2660

Merged
merged 2 commits into from Nov 27, 2021
Merged

Fix tab switching #2660

merged 2 commits into from Nov 27, 2021

Conversation

haslinghuis
Copy link
Member

After #2633 we found out that switching to cli tab we need some timeout to execute the MSP commands if restoreInitialSettings is called. Adding a timeout of 100ms should solve the issue.

@haslinghuis haslinghuis added this to the 10.8.0 milestone Nov 20, 2021
@haslinghuis haslinghuis self-assigned this Nov 20, 2021
limonspb
limonspb previously approved these changes Nov 20, 2021
View reviewed changes
@ctzsnooze
Copy link
Member

This works great!
Fixes the problem.
A long-term fix will be to remove the need to save values in the firmware, ie have MSP do the calculations in firmware and return the values to Configurator without writing the PID numbers in the firmware.
At the moment, even with this fix, if the user plays with sliders and just disconnects, they will find changes to their PID values that they did not intend to save.

ctzsnooze
ctzsnooze previously approved these changes Nov 24, 2021
View reviewed changes
Finalizing Firmware 4.3 Release automation moved this from To do to Reviewer approved Nov 25, 2021
asizon
asizon previously approved these changes Nov 25, 2021
View reviewed changes
@haslinghuis haslinghuis dismissed stale reviews from asizon, ctzsnooze, and limonspb via a45cc1d November 26, 2021 01:49
Finalizing Firmware 4.3 Release automation moved this from Reviewer approved to Review in progress Nov 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis moved this from Review in progress to Reviewer approved in Finalizing Firmware 4.3 Release Nov 26, 2021
@blckmn
Copy link
Member

blckmn commented Nov 26, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze ctzsnooze merged commit 7040a5b into betaflight:master Nov 27, 2021
Finalizing Firmware 4.3 Release automation moved this from Reviewer approved to Done Nov 27, 2021
limonspb pushed a commit to limonspb/betaflight-configurator that referenced this pull request Nov 27, 2021
@ctzsnooze @limonspb
Merge pull request betaflight#2660 from haslinghuis/fix_tab_switch
a9bfe86 
Fix tab switching
@TheIsotopes TheIsotopes mentioned this pull request Nov 27, 2021
Closed
@haslinghuis haslinghuis deleted the fix_tab_switch branch November 27, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Merged RN: BUGFIX Tested
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haslinghuis @ctzsnooze @blckmn @limonspb @asizon