Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EditorConfig #2734

Merged
merged 1 commit into from Jan 10, 2022
Merged

Update EditorConfig #2734

merged 1 commit into from Jan 10, 2022

Conversation

mathiasvr
Copy link
Contributor

Adds more settings to the .editorconfig.

I noticed some json files are using an indent size of 2 and some 4, do we have a preference?

@haslinghuis
Copy link
Member

Should be 4

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathiasvr mathiasvr mentioned this pull request Jan 4, 2022
Merged
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Jan 9, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Jan 9, 2022
Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Jan 10, 2022
@blckmn
Copy link
Member

blckmn commented Jan 10, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

@haslinghuis haslinghuis merged commit 47ac2eb into betaflight:master Jan 10, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Jan 10, 2022
@mathiasvr mathiasvr deleted the pr-update-editorconfig branch January 29, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees
No one assigned
Labels
build system improvement
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mathiasvr @haslinghuis @blckmn @McGiverGim @limonspb