Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NW.js (0.60.0) #2797

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Bump NW.js (0.60.0) #2797

merged 1 commit into from
Feb 12, 2022

Conversation

haslinghuis
Copy link
Member

Fixes: #2691

@haslinghuis haslinghuis added this to the 10.8.0 milestone Feb 6, 2022
@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 6, 2022
@haslinghuis haslinghuis self-assigned this Feb 6, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Bump NW.js Bump NW.js (0.60.0) Feb 6, 2022
@asizon
Copy link
Member

asizon commented Feb 6, 2022

If this is merged, we definitelly need another RC phase to test all functions arround configurator.

@haslinghuis haslinghuis removed this from Configurator in Finalizing Firmware 4.3 Release Feb 6, 2022
@haslinghuis haslinghuis modified the milestones: 10.8.0, 10.9.0 Feb 6, 2022
@bike797
Copy link

bike797 commented Feb 7, 2022

This pr is very important to decide if Betaflight 4.3 is available or not.
We hope to review it for inclusion in 10.8.0 or 10.8.x.

@asizon
Copy link
Member

asizon commented Feb 7, 2022

@bike797 can you test all functions arround the Configurator, 100% of the features, using all available SO including Android?

@McGiverGim
Copy link
Member

I can confirm the issue with an old (but functional) OMNIBUSF4SD. With the testing version it works perfectly. So the bug exists, and must be fixed. If there is another workaround without incrementing the NW version I don't know.

@haslinghuis haslinghuis added this to For discussion in Finalizing Firmware 4.3 Release via automation Feb 8, 2022
@haslinghuis haslinghuis moved this from For discussion to Configurator in Finalizing Firmware 4.3 Release Feb 8, 2022
@haslinghuis haslinghuis modified the milestones: 10.9.0, 10.8.0 Feb 8, 2022
@haslinghuis haslinghuis requested review from a team and removed request for a team February 12, 2022 01:19
@ctzsnooze
Copy link
Member

This appears to do no harm nor fix anything on Mac OSX

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Feb 12, 2022
@blckmn
Copy link
Member

blckmn commented Feb 12, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit e78b0f3 into betaflight:master Feb 12, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Feb 12, 2022
@haslinghuis haslinghuis deleted the bump_nwjs branch February 12, 2022 23:05
@asizon asizon linked an issue Feb 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

NW.js error dialogue on startup USB/Serial Port connection issue - windows10 (not english version)
6 participants