New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert NWjs for Linux only #2856
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
AUTOMERGE: (FAIL)
|
osd elements relocation works fine in portable version under Fedora OS |
I can also confirm that that PR fixes the issue on ubuntu |
@haslinghuis could you please point me what is going to happen if we rever it for Windows too? |
@limonspb please read the link in the opening of this PR. |
Mike on Slack did report an issue:
After updating NWjs
0.54.1
to0.60.0
it seems OSD elements can't be moved on Linux platform.We need NWjs >=
0.59.x
for Windows users so we can't simply revert to0.54.1
So this is a temporary fix until we have a better solution.
See #2797 for more details
EDIT: With Node 16 it's working with NWjs 0.62 ( not with 0.60 ), but there is still a big area appearing while selecting and moving an element which can be resolved by disabling the line on 2355: