Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert NWjs for Linux only #2856

Merged
merged 1 commit into from Mar 30, 2022
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 14, 2022

Mike on Slack did report an issue:

After updating NWjs 0.54.1 to 0.60.0 it seems OSD elements can't be moved on Linux platform.
We need NWjs >= 0.59.x for Windows users so we can't simply revert to 0.54.1

So this is a temporary fix until we have a better solution.

See #2797 for more details

EDIT: With Node 16 it's working with NWjs 0.62 ( not with 0.60 ), but there is still a big area appearing while selecting and moving an element which can be resolved by disabling the line on 2355:

ev.dataTransfer.setDragImage($(this).data('field').preview_img, offsetX, offsetY);

@haslinghuis haslinghuis added this to the 10.8.0 milestone Mar 14, 2022
@haslinghuis haslinghuis self-assigned this Mar 14, 2022
@haslinghuis haslinghuis added this to Bug Tracker in Finalizing Firmware 4.3 Release via automation Mar 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis moved this from Bug Tracker to Configurator in Finalizing Firmware 4.3 Release Mar 14, 2022
@blckmn
Copy link
Member

blckmn commented Mar 15, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@mituritsyn
Copy link
Contributor

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Debug-Android Betaflight-Configurator-Debug-Linux Betaflight-Configurator-Debug-macOS Betaflight-Configurator-Debug-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

osd elements relocation works fine in portable version under Fedora OS

@schugabe
Copy link
Contributor

I can also confirm that that PR fixes the issue on ubuntu

@limonspb
Copy link
Member

@haslinghuis could you please point me what is going to happen if we rever it for Windows too?

@haslinghuis
Copy link
Member Author

@limonspb please read the link in the opening of this PR.

Finalizing Firmware 4.3 Release automation moved this from Configurator to Firmware Mar 30, 2022
@asizon asizon merged commit 2a7cc43 into betaflight:master Mar 30, 2022
Finalizing Firmware 4.3 Release automation moved this from Firmware to Finished (Merged) Mar 30, 2022
@haslinghuis haslinghuis deleted the revert_nwjs_linux branch March 30, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants