Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove antiGravityMode and change iTermAcceleratorGain to antiGravityGain #2953

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Remove antiGravityMode and change iTermAcceleratorGain to antiGravityGain #2953

merged 1 commit into from
Aug 3, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jun 20, 2022 •
edited
Loading

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jun 20, 2022
@haslinghuis haslinghuis self-assigned this Jun 20, 2022
@haslinghuis haslinghuis force-pushed the remove-anti-gravity-step-mode branch from 05ff5d8 to 52708dd Compare June 20, 2022 00:40
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the remove-anti-gravity-step-mode branch 2 times, most recently from 9fbbb79 to 90657b4 Compare June 20, 2022 01:35
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Jun 20, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

limonspb
limonspb previously approved these changes Jun 27, 2022
View reviewed changes
KarateBrot
KarateBrot previously approved these changes Jun 27, 2022
View reviewed changes
blckmn
blckmn previously approved these changes Jun 29, 2022
View reviewed changes
@haslinghuis
Copy link
Member Author

Needs rework now betaflight/betaflight#11656 has been superseded by betaflight/betaflight#11679

@haslinghuis haslinghuis dismissed stale reviews from blckmn, KarateBrot, and limonspb via 13ff9e4 July 25, 2022 14:30
@haslinghuis haslinghuis force-pushed the remove-anti-gravity-step-mode branch from 90657b4 to 13ff9e4 Compare July 25, 2022 14:30
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the remove-anti-gravity-step-mode branch 2 times, most recently from 6fe9394 to c0c022a Compare July 25, 2022 14:50
@haslinghuis haslinghuis force-pushed the remove-anti-gravity-step-mode branch from c0c022a to 7e3ff0b Compare July 25, 2022 14:52
@haslinghuis haslinghuis changed the title Remove antiGravityMode Remove antiGravityMode and change iTermAcceleratorGain to antiGravityGain Jul 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

ctzsnooze commented Aug 1, 2022 •
edited
Loading

This seems really good to me. For 4.4 it definitely shows the correct value.
Thanks, Mark - great work!
Approved.

@blckmn blckmn merged commit 7bc1db4 into betaflight:master Aug 3, 2022
@haslinghuis haslinghuis deleted the remove-anti-gravity-step-mode branch August 3, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot left review comments

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@asizon asizon Awaiting requested review from asizon

Assignees

@haslinghuis haslinghuis

Labels
Needs coordination with betaflight RN: IMPROVEMENT
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @ctzsnooze @limonspb @KarateBrot