Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ELRS UID - Co-authored-by: @jeffpearce #3097

Merged
merged 4 commits into from Dec 5, 2022
Merged

Add support for ELRS UID - Co-authored-by: @jeffpearce #3097

merged 4 commits into from Dec 5, 2022
+934 −17

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 29, 2022 •
edited

Fixes: #2721

Co-authored-by: @jeffpearce

Only have fixed the import of the package in Cordova and some UI styling.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Nov 29, 2022
@haslinghuis haslinghuis self-assigned this Nov 29, 2022
@haslinghuis haslinghuis force-pushed the passphrase branch 4 times, most recently from 9f8f956 to 4082c5f Compare November 29, 2022 04:24
@blckmn
Copy link
Member

blckmn commented Nov 29, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
freasy
freasy reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@freasy freasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LQGTM

gulpfile.js Outdated Show resolved Hide resolved
src/js/tabs/receiver.js Outdated Show resolved Hide resolved
src/js/tabs/receiver.js Outdated Show resolved Hide resolved
src/js/tabs/receiver.js Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis mentioned this pull request Dec 2, 2022
Closed
@nerdCopter
Copy link
Member

  • The UI & firmware setting worked for me.
  • I did not test bind due to not being ready to flash my module to ELRS 3.

@nerdCopter
Copy link
Member

may need some css to make text-field look same as others.

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 4, 2022 •
edited

Here is my attempt:

image

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented Dec 4, 2022 •
edited

looks prefect.... do you have light-mode done too? i dont feel like reflashing my whoop today for testing :D

@blckmn blckmn merged commit 6242f1e into betaflight:master Dec 5, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 5, 2022
@haslinghuis haslinghuis deleted the passphrase branch December 5, 2022 11:14
@haslinghuis haslinghuis changed the title Add support for ELRS UID Add support for ELRS UID - Co-authored-by: @jeffpearce Dec 5, 2022
@McGiverGim McGiverGim mentioned this pull request Dec 5, 2022
Merged
@haslinghuis haslinghuis mentioned this pull request Dec 29, 2022
Merged
This was referenced Jan 17, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freasy freasy freasy left review comments

@jeffpearce jeffpearce jeffpearce approved these changes

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@haslinghuis haslinghuis

Labels
Ready to Merge RN: FEATURE
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@haslinghuis @blckmn @nerdCopter @jeffpearce @freasy @ctzsnooze @sugaarK