fix: cordova browserify/rollup conflict #3180
Conversation
|
Noticed regression on #3001 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
|
The OTG seems to be working, some tabs seems to fail, but I'm not sure if they failed before this PR. |
|
@McGiverGim Which tabs are failing? |
browserify seems to clash with rollup setup, remove browserify in favour of rollup.
chmelevskij
force-pushed
the
fix/cordova-build
branch
from
07cb098
to
4890ca2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -11,14 +11,12 @@ const del = require('del'); | |||
| const NwBuilder = require('nw-builder'); | |||
| const innoSetup = require('@quanle94/innosetup'); | |||
| const deb = require('gulp-debian'); | |||
| const conffiles = './test/configs'; | |||
There was a problem hiding this comment.
This was added in #3155 - need to check if linux debian file is still being created.
UPDATE: Seems to be there. So all good.
There was a problem hiding this comment.
This literally does nothing. Do you mean
betaflight-configurator/gulpfile.js
Line 752 in 4890ca2
There was a problem hiding this comment.
Yes according the example in the updated library
|
Do you want to test this code? Here you have an automated build: |
The RX tab didn't load for example. The OSD tab load but it's very ugly at least for HD but I'm pretty sure this was ugly before this PR. |
|
|
@chmelevskij @McGiverGim Have found the PR which causes receiver tab bug: #3097 |
browserify seems to clash with rollup setup, remove browserify in favour of rollup.
If someone has OTG cable to verify would be great before merging.
Fixes:
