Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gulp-debian library #3155

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Bump gulp-debian library #3155

merged 1 commit into from
Dec 25, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 19, 2022 •
edited

Fixes: #3154

The gulp-debian library has been updated with xz as default compression type..

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 19, 2022
@haslinghuis haslinghuis self-assigned this Dec 19, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis
Copy link
Member Author

@nerdCopter please check

@haslinghuis
Copy link
Member Author

@McGiverGim build size stays the same. Why is it much larger then other archs?

@blckmn
Copy link
Member

blckmn commented Dec 19, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is wrong. The compressFiles is only used to generate the portable version of the Configurator. For the .deb´ version all is in the release_deb` method.
I think remember we have a complete discussion about this in an earlier issue?

@McGiverGim
Copy link
Member

Here was the discussion: #2930

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as draft December 19, 2022 11:36
@nerdCopter
Copy link
Member

Betaflight-Configurator-Linux

dpkg-deb: error: archive 'betaflight-configurator_10.9.0-debug-dff477f_amd64.deb' uses unknown compression for member 'control.tar.zst', giving up

gulp-debian maintainer is not responsive. research alludes that he left coding outside of employment. I've personally tried a few (failing) methods to get this to work, but i only thing modding gulp-debian will be the fix.

@nerdCopter
Copy link
Member

One method would be dpk-deb -Zxz ... on this line: https://github.com/stpettersens/gulp-debian/blob/189c808db3d146fcbcaed62182a177bd58aa1b2a/index.js#L194

Another should be: but i failed at all attempts
image
via https://raphaelhertzog.com/2010/09/17/how-to-create-debian-packages-with-alternative-compression-methods/

@haslinghuis haslinghuis changed the title Disable compression for linux Create alias for dpkg-deb to change compression type Dec 19, 2022
@haslinghuis haslinghuis force-pushed the change-dkpg-compression branch 2 times, most recently from d8c6c98 to 934b7a2 Compare December 19, 2022 16:04
nerdCopter
nerdCopter reviewed Dec 19, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -85,6 +85,10 @@ jobs:
distribution: temurin
java-version: '8'

- run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if: ${{ matrix.name == 'Linux' }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes was waiting for the workflow to continue.

Did you check compression?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one failed; waiting for latest.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

nerdCopter commented Dec 19, 2022 •
edited

4e30b3d still failed :(
dpkg-deb: error: archive 'betaflight-configurator_10.9.0-debug-4e30b3d_amd64.deb' uses unknown compression for member 'control.tar.zst', giving up

Alias certainly should have worked.

@haslinghuis haslinghuis force-pushed the change-dkpg-compression branch 3 times, most recently from b5fbabd to 3245067 Compare December 19, 2022 17:39
@haslinghuis
Copy link
Member Author

Guess the alias does not transfer between different run items. In last push the alias should now be available.

@github-actions

This comment has been minimized.

Sign in to view
@nerdCopter
Copy link
Member

Betaflight-Configurator-Linux
c1beb0f fail, same.

@haslinghuis haslinghuis force-pushed the change-dkpg-compression branch 3 times, most recently from d085723 to db7d6ea Compare December 24, 2022 22:06
@haslinghuis
Copy link
Member Author

We are now on version 0.3.2 :)

@sonarcloud
Copy link

sonarcloud bot commented Dec 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis mentioned this pull request Dec 25, 2022
Merged
@haslinghuis haslinghuis marked this pull request as ready for review December 25, 2022 00:30
@haslinghuis haslinghuis moved this from To do to In progress in Finalizing Firmware 4.4 Release Dec 25, 2022
McGiverGim
McGiverGim approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it! 😋

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Use gulp-debian locally and change compression type Bump gulp-debian library Dec 25, 2022
@haslinghuis haslinghuis merged commit 23b74d9 into betaflight:master Dec 25, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Dec 25, 2022
@haslinghuis haslinghuis deleted the change-dkpg-compression branch December 25, 2022 01:31
@nerdCopter
Copy link
Member

04357b0 tested as installable on Debian 11 and Xubuntu 22.04 💪

This was referenced Dec 29, 2022
Merged
Closed
haslinghuis
haslinghuis commented Jan 9, 2023
View reviewed changes
gulpfile.js
@@ -11,6 +11,7 @@ const del = require('del');
const NwBuilder = require('nw-builder');
const innoSetup = require('@quanle94/innosetup');
const deb = require('gulp-debian');
const conffiles = './test/configs';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed

@haslinghuis haslinghuis mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Assignees

@haslinghuis haslinghuis

Labels
build system improvement dependencies Pull requests that update a dependency file
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

"ZST" Compression Not Supported in Debian dpkg
5 participants
@haslinghuis @blckmn @McGiverGim @nerdCopter @KarateBrot