Refactor msp to modules

[chmelevskij]

Refactors all of the configurator files to use ESM modules.

This doesn't fix any circular dependencies, that will have to come as different PR to reduce amount of changes.

[McGiverGim]

I like more the old way of GUI.log (use a class/object and call the method). This way is outdated/discouraged in modules world?

[chmelevskij]

That thing was causing most of the circular dependencies.

It's not Java or C#, there it literally no need to use classes here. Classes only make sense of data is stateful, this log does literally nothing more than reach into dom and append message. There is no need for it to be in class.

[chmelevskij]

GUI in general is used in soooo many places and needs splitting up. log should be it's own module/logic. But that's refactor for future. Now just fixing obvious issues.

[blckmn]

Can we just call it log? Does it need gui_ ? That way you're just removing 'GUI.' and it's a suitable compromise.

[McGiverGim]

It's the log that appears in the GUI, in the upper part. We have too the console log. It's good to differentiate them.

[chmelevskij]

Open for other naming. We also have logging tab and as @McGiverGim have console.log so its rather overloaded term.

[haslinghuis]

usbDevices not defined while flashing.

[chmelevskij]

@haslinghuis Fixed usbDevices export.

[haslinghuis]

@chmelevskij thanks, as far I could test everything seems to work

Please fix yarn test

Tried to work it out but imports get 404. So might be a rollup thing.

[haslinghuis]

Upon further testing found (vtx tab):

Error in event handler: ReferenceError: VtxDeviceStatus is not defined
    at Object._getDeviceStatusClass (<URL>)
    at Object.createVtxDeviceStatus (<URL>)
    at MspHelper.process_data (<URL>)
    at <URL>
    at Array.forEach (<anonymous>)
    at Object.notify (<URL>)
    at Object._dispatch_message (<URL>)
    at Object.read (<URL>)
    at read_serial (<URL>)
main.html#:1 Error in event handler: ReferenceError: VtxDeviceStatus is not defined
    at Object._getDeviceStatusClass (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/main.js:853:13)
    at Object.createVtxDeviceStatus (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/main.js:835:43)
    at MspHelper.process_data (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/main.js:1102:69)
    at chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/msp.js:233:13
    at Array.forEach (<anonymous>)
    at Object.notify (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/msp.js:232:24)
    at Object._dispatch_message (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/msp.js:223:14)
    at Object.read (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/msp.js:202:22)
    at read_serial (chrome-extension://ajdoecjhplhoahggfmgflfnlechcljoc/js/main.js:4625:13)

[chmelevskij]

@haslinghuis I think I've fixed the VtxDeviceStatus issue

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.4% Duplication

[haslinghuis]

Testing now :)

Yes vtxDeviceStatus looks like to be solved now !!!

🎉 🥳 ❤️

We should merge this soon.

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!