Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motor reorder dialog fix: importing serial backend #3235

Merged
merged 1 commit into from Jan 13, 2023
Merged

Motor reorder dialog fix: importing serial backend #3235

merged 1 commit into from Jan 13, 2023

Conversation

limonspb
Copy link
Member

@limonspb limonspb commented Jan 12, 2023 •
edited

Dialog was crashing at "SAVE" click.

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member

Already fixed in #3214 :)

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@limonspb
Copy link
Member Author

limonspb commented Jan 12, 2023 •
edited

Already fixed in #3214 :)

that one still a draft, but people need to test "today" :)

@blckmn
Copy link
Member

blckmn commented Jan 12, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jan 13, 2023
@blckmn blckmn merged commit d9e119f into betaflight:master Jan 13, 2023
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 13, 2023
@haslinghuis haslinghuis mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@limonspb limonspb

Labels
Cleanup
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@limonspb @haslinghuis @blckmn