Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSP support for led profile and status #3671

Merged
merged 1 commit into from Dec 15, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 14, 2023

Finally add support for betaflight/betaflight#7491

Added a flag indicating the level of ledstrip support (to allow improved Configurator behavior) along with support for reading/setting the current ledstrip_profile [RACE, BEACON, STATUS]

ledstrip support flag [STATUS] is as follows:
0 = basic ledstrip available
1 = advanced ledstrip available

In follow up we could do something useful with this.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 14, 2023
@haslinghuis haslinghuis self-assigned this Dec 14, 2023
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

The distinction between basic and complex profiles is no longer relevant.
The whole LED code needs to be refactored without that distinction.
We should not change MSP to add a new element now, because it is likely to be unnecessary when the LED code is properly modernised.

@haslinghuis
Copy link
Member Author

This is not a change. Just implementing current firmware behavior. Any changes to that can be done in subsequent PR.

@blckmn
Copy link
Member

blckmn commented Dec 15, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit b8da48a into betaflight:master Dec 15, 2023
7 checks passed
@haslinghuis haslinghuis deleted the fix-msp-led-support branch December 15, 2023 00:28
haslinghuis added a commit that referenced this pull request Dec 23, 2023
haslinghuis added a commit that referenced this pull request Dec 24, 2023
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants