Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add MSP support for led profile and status (#3671)" #3692

Merged
merged 1 commit into from Dec 24, 2023
Merged

Revert "Add MSP support for led profile and status (#3671)" #3692

merged 1 commit into from Dec 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 23, 2023 •
edited

Fixes #3691

This reverts commit b8da48af95c12d47e864529642a3e5a8e2baaf31so let's roll this to next release.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 23, 2023
@haslinghuis haslinghuis self-assigned this Dec 23, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@TheIsotopes TheIsotopes mentioned this pull request Dec 23, 2023
Closed
@blckmn
Copy link
Member

blckmn commented Dec 23, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 1c78f88 into master Dec 24, 2023
7 checks passed
@haslinghuis haslinghuis deleted the revert-3671-fix-msp-led-support branch December 24, 2023 19:41
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Revert "Add MSP support for led profile and status (betaflight#3671)" (…
581e7ef 
…betaflight#3692)

This reverts commit b8da48a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@blckmn blckmn blckmn approved these changes

@chmelevskij chmelevskij Awaiting requested review from chmelevskij

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@asizon asizon Awaiting requested review from asizon

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@haslinghuis haslinghuis

Labels
Cleanup Ready to Merge Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

Save Button on LED Tab not working
3 participants
@haslinghuis @blckmn @McGiverGim