Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 fixes #260

Merged
merged 2 commits into from
Oct 14, 2019
Merged

1.4.0 fixes #260

merged 2 commits into from
Oct 14, 2019

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Oct 14, 2019

This is an attempt at fixing 2 issues seen with 1.4.0:

  • "BF script page changed when switch between telemetry page and script":
    • NEXT_PAGE / PREV_PAGE events are now only evaluated when the script is not executed as a telemetry script.
  • "values changed back after editing":
    • this is probably caused by the fixed page reading timeout (800ms) generating multiple requests.
    • when the first reply has arrived, the user starts editing the page.
    • when the next reply arrives, the changes are wiped.
    • the fix invalidates subsequent replies.

Please use this zip file to test:
bf_lua-1.4.0-fixes.zip

@0crap
Copy link
Contributor

0crap commented Oct 14, 2019

@raphaelcoeffic bf_lua-1.4.0-fixes.zip contains only empty folders.

@raphaelcoeffic
Copy link
Member Author

@0crap sorry about that, it's fixed now.

Copy link
Contributor

@0crap 0crap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the PAGE button is solved. Tested on my Taranis QX7S.
The other issue in this PR, I can't comment on that one because I have not seen that specific problem.

Thx!

@mikeller mikeller merged commit 578e60b into betaflight:master Oct 14, 2019
@mikeller mikeller added this to the 1.4.1 milestone Oct 14, 2019
@johnelliott
Copy link

johnelliott commented Oct 14, 2019

Thanks for doing this so quickly, I just experienced the bf page flipping bug and was making a video to post.

Update: worked for me to fix the bug :)

mikeller added a commit to mikeller/betaflight-tx-lua-scripts that referenced this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants