Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud build not working - BLACKBOX as custom define needed #12503

Closed
TheIsotopes opened this issue Mar 11, 2023 · 10 comments · Fixed by #12511
Closed

Cloud build not working - BLACKBOX as custom define needed #12503

TheIsotopes opened this issue Mar 11, 2023 · 10 comments · Fixed by #12511
Labels
Template: Bug Set by auto_close_issue.

Comments

@TheIsotopes
Copy link
Contributor

TheIsotopes commented Mar 11, 2023

Describe the bug

Cloud build on controllers with flash are failing,

MATEKF722MINI - https://build.betaflight.com/api/builds/e0ad5890a8b645c12a774baac1d8b5ee/log
MATEKF405TEMINI - https://build.betaflight.com/api/builds/778a85a1199c15736fe559ea8bafbeff/log

but with sdcard all is working.

MATEKH743 - https://build.betaflight.com/api/builds/833dfb1640297473a36c22875205bc29/log

@haslinghuis @blckmn please can someone check this.

EDIT: with BLACKBOX as custom defines its working. https://build.betaflight.com/api/builds/d23a06bb3683225537bbe984e4ccee49/log

To Reproduce

use cloud build on controllers with flash like MATEKF722MINI, MATEKF405TEMINI

Expected behavior

working cloud build

Support ID

xxx

Flight controller

MATEKF722MINI, MATEKF405TEMINI

Other components

No response

How are the different components wired up (including port information)

No response

Add any other context about the problem that you think might be relevant here

No response

@TheIsotopes TheIsotopes added the Template: Bug Set by auto_close_issue. label Mar 11, 2023
@TheIsotopes
Copy link
Contributor Author

fixed in #12504

@TheIsotopes
Copy link
Contributor Author

TheIsotopes commented Mar 11, 2023

reopen again ... BLACKBOX as custom defines is still needed. otherwise no option to configure will be displayed in the blackbox configurator.

@blckmn any ideas?

Screenshot 2023-03-11 105016

@TheIsotopes TheIsotopes changed the title Cloud build not working Cloud build not working - BLACKBOX as custom define needed Mar 11, 2023
@blckmn
Copy link
Member

blckmn commented Mar 11, 2023

This should now be resolved.

@TheIsotopes
Copy link
Contributor Author

@blckmn nope ... not working.

Another question. How can i rebuild a cached build?

@blckmn
Copy link
Member

blckmn commented Mar 11, 2023

@blckmn nope ... not working.

Another question. How can i rebuild a cached build?

Sorry the original build error.

Will add Blackbox as an option.

@blckmn
Copy link
Member

blckmn commented Mar 11, 2023

Rebuilding a cached build... easiest option is to put the current master commit hash into the commit option.

Unless something has changed the result will be the same :)

@haslinghuis
Copy link
Member

haslinghuis commented Mar 12, 2023

Tested master 4.5 cloud build:

  • MATEKF405TEMINI and MATEKH743 working
  • SPEEDYBEEF7V3, KAKUTEH7 and KAKUTEH7MINI needs BLACKBOX as custom define
  • CRAZYBEEF4SX1280 or MAMBA740MK4 does not work with or without BLACKBOX as custom define

@TheIsotopes
Copy link
Contributor Author

TheIsotopes commented Mar 12, 2023

@haslinghuis that's weird,
I don't know how you tested it, but the MATEKF045TEMINI doesn't work.
Just tried it, blackbox as an option is not in the list and without custome defines, the settings do not appear in the configurator.
MATEKH743 does not have this problem as it works with sd card as i said above.
imho this only affects fc's with flash memory.

@haslinghuis
Copy link
Member

Okay today have to add BLACKBOX to custom defines to get it working.
MATEKH743 is working because it already has the USE_BLACKBOX define.

image

https://build.betaflight.com/api/builds/4e05623427e5c0a4dff1eb95efb56b59/log

image

@TheIsotopes
Copy link
Contributor Author

MATEKH743 is working because it already has the USE_BLACKBOX define.

and he is the only one with this define.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template: Bug Set by auto_close_issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants