Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFIG: Fix blackbox #12511

Merged
merged 2 commits into from Mar 13, 2023
Merged

CONFIG: Fix blackbox #12511

merged 2 commits into from Mar 13, 2023

Conversation

haslinghuis
Copy link
Member

Fixes: #12503

Don't know if it's better to add USE_BLACKBOX to each board having either USE_FLASH or USE_SDCARD defined.

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 12, 2023
@haslinghuis haslinghuis self-assigned this Mar 12, 2023
@github-actions

This comment has been minimized.

Sign in to view
@TheIsotopes
Copy link
Contributor

@haslinghuis I would prefer it like this PR.
we should then delete it in MATEKH743. It is the only one where it is in the config file.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Mar 12, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 53dbad7 into betaflight:master Mar 13, 2023
@haslinghuis haslinghuis deleted the fix-blackbox branch March 13, 2023 09:59
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
CONFIG: Fix blackbox (betaflight#12511)
5176c35 
* CONFIG: Fix blackbox

* Remove blackbox from MATEKH743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@TheIsotopes TheIsotopes TheIsotopes approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Cloud build not working - BLACKBOX as custom define needed
3 participants
@haslinghuis @TheIsotopes @blckmn