Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #10388: 'Fix BIDIR UART issue' in maintenance branch. #10445

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented Jan 3, 2021

Reverting because of problems described in #10435 - we need more time to investigate / fix.

@mikeller mikeller force-pushed the revert-10388_in_maintenance_branch branch from 4efd895 to 3e8dd7d Compare January 3, 2021 13:52
@tonycake
Copy link
Contributor

tonycake commented Jan 4, 2021

Sorry guys, reverting a change that fixes potentially serious issues with control (any single-wire Rx), for something that fixes vTx control is nuts.
Mike, you mentioned that we might need a flag to let Smart audio live with the previous (bad) behaviour. That might be how we need to handle this. If you need me to code this up, I am happy to.
I am not happy to see this critical fix un-done though.

@mikeller
Copy link
Member Author

mikeller commented Jan 4, 2021

@tonycake: This is only reverting this for the current maintenance branch - this does not affect the master branch that will eventually become 4.3.
It is Betaflight policy to manage maintenance / patch release in such a way that they only contain uncontroversial bugfixes and changes that are safety relevant, in such a way that users with a currently working setup on a given release can update to the next patch version of the same release without having to worry about their setup breaking.
In this light, cherry-picking #10388 into the maintenance branch was the wrong decision, as it turned out to break currently working setups - apologies for that.

@mikeller mikeller merged commit a4b6db1 into betaflight:4.2-maintenance Jan 5, 2021
@mikeller mikeller deleted the revert-10388_in_maintenance_branch branch January 5, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants