New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spelling fixes in documentation #10800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this was really bad. Thanks for taking the time to fix this!
docs/Cli.md
Outdated
@@ -200,14 +200,14 @@ Click on a variable to jump to the relevant documentation page. | |||
| `imu_dcm_kp` | Inertial Measurement Unit KP Gain | 0 | 20000 | 2500 | Master | UINT16 | | |||
| `imu_dcm_ki` | Inertial Measurement Unit KI Gain | 0 | 20000 | 0 | Master | UINT16 | | |||
| `alt_hold_deadband` | Altitude will be held when throttle is centered with an error margin defined in this parameter. | 1 | 250 | 40 | Profile | UINT8 | | |||
| `alt_hold_fast_change` | Authorise fast altitude changes. Should be disabled when slow changes are prefered, for example for aerial photography. | OFF | ON | ON | Profile | UINT8 | | |||
| `alt_hold_fast_change` | Authorize fast altitude changes. Should be disabled when slow changes are preferred, for example for aerial photography. | OFF | ON | ON | Profile | UINT8 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Authorise" is also correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert this change. If there's no clear improvement in readability, the change is not useful.
docs/Inflight Adjustments.md
Outdated
|
||
Both modes utilise two channels to make an adjustment. | ||
Both modes utilize two channels to make an adjustment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Utilise" is also correct. In Betaflight we often use the Queen's english
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree again ;-) But the queen is more vivid than the American president 🐰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both spellings are valid and that's a fact lol. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, welcome to Babylonia / Babilonia 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I prefer to revert this one, no change is the best change. Oh, and God Save the Queen!
docs/Failsafe.md
Outdated
@@ -103,7 +103,7 @@ Configure the RC switched failsafe action. It can be one of: | |||
|
|||
Time throttle level must have been below 'min_throttle' to _only disarm_ instead of _full failsafe procedure_. | |||
|
|||
Use standard RX usec values. See [Rx documentation](Rx.md). | |||
Use standard RX used values. See [Rx documentation](Rx.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think this is supposed to be "usec" as in microseconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting ! But then it should be microsecond values
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I suggest I put us
, which is already used in cli.md. The other option would be to use the standard SI prefix, μs
: https://en.wikipedia.org/wiki/Metric_prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer the latter. @klutvott123 ?
“Color” is only used in the USA. “Colour” is used in the rest of the world. Since most of Betaflights user base are non-Amercian we should be using “Colour”. |
@Zuldan The word color has its roots (unsurprisingly) in the Latin word |
Oh common @haslinghuis. I’m trying to add fuel to the fire. What random website did you find that reference? Lol |
Remove your cookies before the search |
Hahah! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@klutvott123 Thanks for the review. Am I supposed to do something to get this PR merged, or just wait? |
@dimag0g All is good, please just wait for merging. |
@dimag0g You don't have to do anything. We wait at least 24 hours after approval before merging but it can take longer. 🙂 |
No description provided.