Fix stats

[haslinghuis]

Fixes: #10936

[limonspb]

yeah i do not know if that's the right approach. It will mess up this scenario:

1. plug your quad
2. Change PIDs/rates via OSD menu of via switches
3. Don't save - exit no save
4. Fly, land, disarm (with new PIDs/Rates)

At this point user has an option - he can go ahead and save changes via OSD
or he can unplug if he does not want these changes to be saved.

Now if we introduce stats without checking that condition, it will automatically save everything on disarm including new PIDs Rates etc.

[haslinghuis]

Yes what I said before:

Agree. But it's an expensive operation. So we just have to make sure the dirty flag is set.

[limonspb]

I don't think it's about how expensive the operation is, it's about unexpected saves of PIDs for the user when he does not expect them to be saved yet.

[haslinghuis]

Then we have to make sure the dirty flag is set on the right place

[limonspb]

@haslinghuis i think so yes. That could be more complicated, i could not figure that out from the first look :)

[haslinghuis]

Build is ready - so you could check implications of it. Otherwise it's not obvious where it fails yet.

[haslinghuis]

Closing as known limitation: #10936 (comment)