Don't allow bidirectional DSHOT600 on an F411 #11222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllusionFpv
approved these changes
Jan 3, 2022
haslinghuis
approved these changes
Jan 3, 2022
haslinghuis
added this to For discussion
in Finalizing Firmware 4.3 Release
via automation
haslinghuis
moved this from For discussion
to In Progress
in Finalizing Firmware 4.3 Release
daleckystepan
approved these changes
Jan 3, 2022
mathiasvr
approved these changes
Jan 3, 2022
klutvott123
approved these changes
Jan 3, 2022
ctzsnooze
approved these changes
Jan 4, 2022
This was referenced Jan 4, 2022
|
Do not merge as will be included in #11198 |
haslinghuis
moved this from Notes
to Steve's PR in Mashup
in Finalizing Firmware 4.3 Release
|
Merged with #11198 |
Finalizing Firmware 4.3 Release
automation
moved this from Steve's PR in Mashup
to Finished (Merged)
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11221
This PR adds an additional check to
validateAndFixGyroConfig()which detects an attempt to use bidirectional DSHOT600 on an F411 and if found will force DSHOT300. In turn this will result in the pid loop denominator being set appropriately for DSHOT300, which with an MPU6000 gyro, for example, will mean a 4K PID loop. With a BMI160 gyro the loop time would not be affected.Usability is important and whilst automatic application of settings contrary to what the user has selected is bad, this avoids "this firmware has bricked my FC" type claims.