Ghost MSP support #11242

daleckystepan · 2022-01-07T16:59:48Z

Add MSP support for Ghost

Need new Ghost FW v1.0.6.0+

ETX: EdgeTX/edgetx#1377
LUA: betaflight/betaflight-tx-lua-scripts#419

Thanks to @klutvott123 for helping me
FYI: @TheIsotopes @tonycake

TheIsotopes · 2022-01-07T17:29:36Z

@daleckystepan The only thing i missing is the public beta of Ghost FW 1.0.6.0 and also the support for OpenTX, then I could test this too.

TheIsotopes · 2022-01-11T17:52:20Z

deleted -> all clarified on discord.

TheIsotopes · 2022-02-03T15:14:34Z

@daleckystepan am not up to date. is there anything new or is this pr still up to date?
today i was flying again, used rc3 with this pr and everything is going great.

daleckystepan · 2022-02-03T17:28:55Z

@TheIsotopes nothing new. Only rebase.

blckmn · 2022-04-21T05:17:58Z

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> PASS
approver count at least three -> PASS

TheIsotopes · 2022-05-28T13:30:39Z

@daleckystepan Didn't think it would take so long with the 4.3 release.
It would have been nice if the Ghost modifications had been included.

TheIsotopes · 2022-07-11T09:56:10Z

@daleckystepan @tonycake Any news when this PR will merged?

sugaarK · 2022-07-11T14:11:17Z

@daleckystepan @tonycake Any news when this PR will merged?

When we get some testing direction from @tonycake

daleckystepan · 2022-07-11T21:12:51Z

I am waiting for green light from Tony.

TheIsotopes · 2022-07-21T07:17:02Z

@daleckystepan @tonycake has anything new come up?
it would be nice if it was merged.

TheIsotopes · 2022-08-06T06:47:18Z

again two weeks have passed. :-(

@tonycake @daleckystepan Something new?
it would be nice if this finally got merged.

sugaarK · 2022-08-06T06:51:13Z

again two weeks have passed. :-(

@tonycake @daleckystepan Something new? it would be nice if this finally got merged.

Happy to merge it when @tonycake gives us the green light.. hunt him down and see what’s up

github-actions · 2022-08-15T17:05:04Z

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

daleckystepan · 2022-08-15T20:52:37Z

We have a green light from @tonycake after additional testing. So please retest, review and we are ready to go if there are no issues.

If you are experiencing any issue, please fill:

ETX version
Ghost TX, RX and their FW version
BF version (hopefully this PR CI builds)

haslinghuis · 2022-08-15T23:18:31Z

src/main/telemetry/ghst.c

+    sbufWriteU8(dst, GHST_PAYLOAD_SIZE + GHST_FRAME_LENGTH_CRC + GHST_FRAME_LENGTH_TYPE);   // lenght
+    sbufWriteU8(dst, GHST_DL_MSP_RESP);                                                 // type
+    sbufWriteData(dst, payload, payloadSize);                                           // payload
+    for(int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) {                          // payload fill zeroes


Suggested change

for(int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) { // payload fill zeroes

for (int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) { // payload fill zeroes

@daleckystepan please fix as we like to merge this PR.

TheIsotopes

works just as well as it did a few months ago. ready to merge.

howels

Looks like this has been tested extensively and we have the ok from Ghost vendor now. Suggest merging before this becomes stale.

haslinghuis · 2022-08-31T22:26:31Z

src/main/telemetry/ghst.c

+    sbufWriteU8(dst, GHST_PAYLOAD_SIZE + GHST_FRAME_LENGTH_CRC + GHST_FRAME_LENGTH_TYPE);   // lenght
+    sbufWriteU8(dst, GHST_DL_MSP_RESP);                                                 // type
+    sbufWriteData(dst, payload, payloadSize);                                           // payload
+    for(int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) {                          // payload fill zeroes


@daleckystepan please fix as we like to merge this PR.

haslinghuis

We can fix the missing space later

TheIsotopes · 2022-09-01T17:44:17Z

Please remember to merge the betaflight/betaflight-tx-lua-scripts#419 with it at the same time.

daleckystepan added this to the 4.4 milestone Jan 7, 2022

This was referenced Jan 7, 2022

Ghost MSP support betaflight/betaflight-tx-lua-scripts#419

Merged

Ghost MSP support EdgeTX/edgetx#1377

Merged

daleckystepan force-pushed the ghst-msp branch 3 times, most recently from 5049c36 to c0061ec Compare January 10, 2022 17:34

haslinghuis added Added by Cherry-pick RN: IMPROVEMENT and removed Added by Cherry-pick labels Jan 10, 2022

haslinghuis assigned daleckystepan Jan 10, 2022

daleckystepan force-pushed the ghst-msp branch 2 times, most recently from de35a48 to 095d485 Compare January 11, 2022 17:11

daleckystepan changed the title ~~[WIP] Ghost MSP support~~ Ghost MSP support Jan 11, 2022

TheIsotopes mentioned this pull request Jan 11, 2022

Ghost MSP Support opentx/opentx#8821

Merged

daleckystepan force-pushed the ghst-msp branch from 095d485 to 96990f0 Compare January 15, 2022 13:15

daleckystepan force-pushed the ghst-msp branch from 96990f0 to a41e73b Compare January 26, 2022 13:13

daleckystepan force-pushed the ghst-msp branch from a41e73b to 85e44d9 Compare February 10, 2022 16:02

daleckystepan force-pushed the ghst-msp branch 2 times, most recently from ea75a74 to 7b0ceaa Compare February 26, 2022 20:12

daleckystepan force-pushed the ghst-msp branch from 7b0ceaa to 0d3460f Compare March 2, 2022 20:51

daleckystepan force-pushed the ghst-msp branch from 0d3460f to feefabe Compare March 11, 2022 15:30

daleckystepan force-pushed the ghst-msp branch from feefabe to 58927ea Compare March 19, 2022 10:54

daleckystepan force-pushed the ghst-msp branch from 58927ea to 9448088 Compare March 31, 2022 20:13

daleckystepan force-pushed the ghst-msp branch from 9448088 to 139ef86 Compare May 28, 2022 11:22

daleckystepan dismissed stale reviews from haslinghuis and klutvott123 via cb06be8 July 21, 2022 11:41

daleckystepan force-pushed the ghst-msp branch from f986ae1 to cb06be8 Compare July 21, 2022 11:41

This comment has been minimized.

Sign in to view

Ghost MSP support

7cf54fc

daleckystepan force-pushed the ghst-msp branch from cb06be8 to 7cf54fc Compare August 15, 2022 17:00

haslinghuis reviewed Aug 15, 2022

View reviewed changes

TheIsotopes reviewed Aug 16, 2022

View reviewed changes

daleckystepan mentioned this pull request Aug 28, 2022

VTX Device over MSP #11705

Merged

howels approved these changes Aug 31, 2022

View reviewed changes

haslinghuis moved this from Firmware to Ready to merge in Finalizing Firmware 4.4 Release Aug 31, 2022

haslinghuis requested changes Aug 31, 2022

View reviewed changes

KarateBrot approved these changes Aug 31, 2022

View reviewed changes

haslinghuis approved these changes Aug 31, 2022

View reviewed changes

klutvott123 approved these changes Sep 1, 2022

View reviewed changes

TheIsotopes approved these changes Sep 1, 2022

View reviewed changes

sugaarK approved these changes Sep 2, 2022

View reviewed changes

haslinghuis merged commit 0cab176 into betaflight:master Sep 2, 2022

Finalizing Firmware 4.4 Release automation moved this from Ready to merge to Closed Sep 2, 2022

haslinghuis added RN: MAJOR FEATURE and removed RN: IMPROVEMENT labels Jan 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ghost MSP support #11242

Ghost MSP support #11242

daleckystepan commented Jan 7, 2022 •

edited

TheIsotopes commented Jan 7, 2022

TheIsotopes commented Jan 11, 2022 •

edited

TheIsotopes commented Feb 3, 2022

daleckystepan commented Feb 3, 2022

blckmn commented Apr 21, 2022 •

edited

TheIsotopes commented May 28, 2022

TheIsotopes commented Jul 11, 2022

sugaarK commented Jul 11, 2022

daleckystepan commented Jul 11, 2022

TheIsotopes commented Jul 21, 2022 •

edited

This comment has been minimized.

TheIsotopes commented Aug 6, 2022

sugaarK commented Aug 6, 2022

github-actions bot commented Aug 15, 2022

daleckystepan commented Aug 15, 2022 •

edited

haslinghuis Aug 15, 2022

haslinghuis Aug 31, 2022

TheIsotopes left a comment

howels left a comment

haslinghuis Aug 31, 2022

haslinghuis left a comment

TheIsotopes commented Sep 1, 2022

	for(int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) { // payload fill zeroes
	for (int i = 0; i < GHST_PAYLOAD_SIZE - payloadSize; ++i) { // payload fill zeroes

Ghost MSP support #11242

Ghost MSP support #11242

Conversation

daleckystepan commented Jan 7, 2022 • edited

TheIsotopes commented Jan 7, 2022

TheIsotopes commented Jan 11, 2022 • edited

TheIsotopes commented Feb 3, 2022

daleckystepan commented Feb 3, 2022

blckmn commented Apr 21, 2022 • edited

TheIsotopes commented May 28, 2022

TheIsotopes commented Jul 11, 2022

sugaarK commented Jul 11, 2022

daleckystepan commented Jul 11, 2022

TheIsotopes commented Jul 21, 2022 • edited

This comment has been minimized.

TheIsotopes commented Aug 6, 2022

sugaarK commented Aug 6, 2022

github-actions bot commented Aug 15, 2022

daleckystepan commented Aug 15, 2022 • edited

haslinghuis Aug 15, 2022

Choose a reason for hiding this comment

haslinghuis Aug 31, 2022

Choose a reason for hiding this comment

TheIsotopes left a comment

Choose a reason for hiding this comment

howels left a comment

Choose a reason for hiding this comment

haslinghuis Aug 31, 2022

Choose a reason for hiding this comment

haslinghuis left a comment

Choose a reason for hiding this comment

TheIsotopes commented Sep 1, 2022

daleckystepan commented Jan 7, 2022 •

edited

TheIsotopes commented Jan 11, 2022 •

edited

blckmn commented Apr 21, 2022 •

edited

TheIsotopes commented Jul 21, 2022 •

edited

daleckystepan commented Aug 15, 2022 •

edited