Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some switch-case-s #11810

Merged
merged 1 commit into from Sep 18, 2022
Merged

Cleanup some switch-case-s #11810

merged 1 commit into from Sep 18, 2022

Conversation

DusKing1
Copy link
Contributor

Just to make them cleaner...

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Aug 25, 2022 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

ledvinap
ledvinap requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@ledvinap ledvinap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting changes are good idea. But use 'default:' only when that path is intentional.

src/main/drivers/mco.c Outdated Show resolved Hide resolved
src/main/drivers/pinio.c Outdated Show resolved Hide resolved
src/main/drivers/pwm_output_dshot_hal.c Outdated Show resolved Hide resolved
@DusKing1
Copy link
Contributor Author

@ledvinap Deleted per your request, anything else that I did wrong?

@DusKing1 DusKing1 requested a review from ledvinap August 29, 2022 10:53
@github-actions

This comment has been minimized.

Sign in to view
@DusKing1 DusKing1 requested a review from ledvinap August 29, 2022 14:03
ledvinap
ledvinap previously approved these changes Aug 29, 2022
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
haslinghuis
haslinghuis requested changes Aug 29, 2022
View reviewed changes
src/main/io/dashboard.c Outdated Show resolved Hide resolved
@DusKing1 @ledvinap @haslinghuis
switch case cleanup
0088eb5 
Co-Authored-By: Petr Ledvina <ledvinap@gmail.com>
Co-Authored-By: haslinghuis <mark@numloq.nl>
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis added this to the 4.3.2 milestone Aug 29, 2022
@KarateBrot KarateBrot modified the milestones: 4.3.2, 4.4 Sep 16, 2022
@haslinghuis haslinghuis moved this from Firmware to Ready to merge in Finalizing Firmware 4.4 Release Sep 18, 2022
SteveCEvans
SteveCEvans approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@SteveCEvans SteveCEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple cleanup

howels
howels approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@howels howels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace removal and indentation changes.

@blckmn blckmn merged commit 8d909fb into betaflight:master Sep 18, 2022
Finalizing Firmware 4.4 Release automation moved this from Ready to merge to Closed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@howels howels howels approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@SteveCEvans SteveCEvans SteveCEvans approved these changes

@ledvinap ledvinap ledvinap left review comments

Assignees
No one assigned
Labels
RN: REFACTORING
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@DusKing1 @blckmn @ledvinap @howels @haslinghuis @SteveCEvans @KarateBrot