Display OSD canvas size in status command #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? Here you have an automated build: |
sugaarK
approved these changes
Dec 29, 2022
|
@SteveCEvans what about a center mark on the osd preview in the configurator? The grid is nice but working out where the middle is.. is tricky |
haslinghuis
approved these changes
Dec 29, 2022
|
AUTOMERGE: (FAIL)
|
Good idea. Not entirely sure how best to do that. Maybe make the grid box red around the character nearest to the centre? |
|
Maybe something like: https://ej2.syncfusion.com/javascript/documentation/diagram/ruler/ Scroll down and click on preview. |
Any thing that’s simple would be sweet |
|
Maybe only the Number for the element in X and Y if you hover over it. |
haslinghuis
approved these changes
Dec 29, 2022
|
Adding this to the status command is a very good idea. |
KarateBrot
approved these changes
Dec 30, 2022
KarateBrot
pushed a commit
to druckgott/betaflight
that referenced
this pull request
Jan 11, 2023
…le (BETAFLIGHTF7) (betaflight#12060) * Update Development.md * Update Development.md * Update Development.md * Update Development.md Update firmware bug report (betaflight#12062) Extend error output (betaflight#12063) Fix nightly build badge (betaflight#12066) Small fix for msp vtx over crsf framing (betaflight#12059) fix for msp vtx over crsf Fixed edt telemetry initial value assignation (betaflight#12074) Add Discord chat badge (betaflight#12075) FIX: Include the legacy drivers (gated) (betaflight#12069) Organize > 512K options (betaflight#12077) Combine all Update LedStrip.md (betaflight#12078) Add resource remapping parent 599a9c6 author haslinghuis <mark@numloq.nl> 1672110935 +0100 committer druckgott <forum@coolpixx.de> 1672311983 +0100 Fix status output (betaflight#12096) Bake in the board information at build time (betaflight#12089) - if provided. First conzept for moving home point on osd screen, 3 parameters: osd_camera_fov_h, osd_camera_fov_v, osd_home_point_pos, currently only changable via cli Fix some points Fix some points Fix some more points Displayport is not working, Ican not get it. Maybe you can help me Did a first try prinzipial the element is moving roughly to the right direction, maybe a compass is needed which I currently do not have, did a fix in for one sign. Add canvas_cols and canvas_rows Update LedStrip.md (betaflight#12078) Add resource remapping FIX: USE_RX_CC2500 was not gating correctly (betaflight#12083) Cloud build option for 64 leds (betaflight#12064) Build option for 64 leds FIX: Assist in debugging by including the build key (betaflight#12085) Center ARMED message and stats (betaflight#12086) Add MSP displayport HD OSD flow diagrams (betaflight#12092) Fix status output (betaflight#12096) Bake in the board information at build time (betaflight#12089) - if provided. First conzept for moving home point on osd screen, 3 parameters: osd_camera_fov_h, osd_camera_fov_v, osd_home_point_pos, currently only changable via cli Fix some points Did a first try prinzipial the element is moving roughly to the right direction, maybe a compass is needed which I currently do not have, did a fix in for one sign. Update maths.h Add support for Omron 2SMBP-02B barometer (betaflight#11173) FIX: MSP Displayport now has dependency on OSD config (betaflight#12106) * FIX: MSP Displayport now has dependency on OSD config See: Center logo and CMS display for HD OSD (betaflight#12056) * CMS is dependent on OSD * Update src/main/io/displayport_msp.c Co-authored-by: Jan Post <Rm2k-Freak@web.de> * A few extra comments (to aid in #endif reconciliation) Fix STM32H750 target support (betaflight#12091) FIX: Barometers tend to be on boards (betaflight#12105) - this removes the inclusion of all the barometers, expectation is the specific baro will be in the config file. - users can still add any baro using the custom defines (to work out what needs updating for the config file) Change Slack by Discord for translators in README (betaflight#12107) Display OSD canvas size in status command (betaflight#12108) Update CreatingAUnifiedTarget.md (betaflight#12090) STM32H730 base target support. (betaflight#12093) * STM32H750 - Don't define a default config storage subsystem. * STM32H730 - Add base target based on the H750 unified target. Improved SDFT windowing (betaflight#12117) Proper SDFT windowing FIX: EXTRA_FLAGS not forcing a rebuild when changed. (betaflight#12116) FIX: Minor re-organisation for classic building (betaflight#12111) * FIX: Minor re-organisation for classic building This is so that even for classic build the drivers can be restricted to those specified in the config file. * Black box can be enabled on its own (cloud build) or if SDCARD or FLASH is enabled. * Alignment * 512 not big enough. Add RX_SPI to RX_CC2500 (betaflight#12124) FIX: CC2500 not building due to undefined pins. (betaflight#12125) See: https://build.betaflight.com/api/builds/4.4.0-RC3/CRAZYBEEF4FR/d84f1a9ce8df5c1907aa7b545100a96a/log FIX: SPI_DPS310 not gated correctly (betaflight#12131) - also fixes FPORT requires USE_TELEMETRY Documentation for SPI/I2C bus (betaflight#12132) Disarm on fail-safe when `allow arming without fix` is enabled and failsafe procedure is set to GPS-RESCUE (betaflight#12120) * Fix performSanityChecks * Override RESCUE_DO_NOTHING Ensure OSD elements are on canvas (betaflight#12144) Fix reset PG behaviour and configurator interactions based on USE_OSD_SD and USE_OSD_HD definitions (betaflight#12152) move fov values Fix Merged Moving_Home_Point Feature cutback making headroom for local development (betaflight#12139) Feature cutback Update artifact-links.yml (betaflight#12157) tonyhallett/artifacts-url-comments#80 Feature cutback making headroom for local development (betaflight#12139) Feature cutback Update artifact-links.yml (betaflight#12157) tonyhallett/artifacts-url-comments#80 Flash M25P16: Add QSPI support (betaflight#12103) Move JETIEXBUS serial RX to targets > 512kb flash. (betaflight#12160) This is inline with the telemetry settings. Those who want JETIEXBUS on smaller targets will need to perform a cloud build and select it as an option. Fix removing USE_LED_STRIP (betaflight#12162) Add osd_canvas_width/height variables (betaflight#12164) Add gate for ICM20602 (betaflight#12161) Use Support ID in issue template (betaflight#12165) Avoid debugging other data than RPM telemetry when decoding DSHOT RPM (betaflight#12166) Improve performance for ELRS SX1280 SPI callbacks and SPI/ELRS handlers. (betaflight#11460) * SPI - Mark the SPI IRQ handler as FAST_IRQ_HANDLER. Since it's used by both the gyro code, at 8k (or 2x8k on dual gyro boards) having it in RAM removes a significant amount of potential flash latency. It is also used by the ELRS SPI code. The ELRS code runs at 500hz, but each cycle uses multiple SPI transfers, for clear irq, read, start-recieving, change-frequency, etc. I.e. invokd at least 1000hz in addition to gyro reads. * ELRS - Move some frequently used functions to RAM and mark some irq handlers as FAST. * SPI/LL - Move some frequently called code to FAST_CODE. Also remove some invalid characters that Eclipse with encoding as UTF-8 complained about. * SPI - Mark the spiRx and spiTx dma handlers as FAST_IRQ_HANDLER. * Filter - move nullFilterApply out of FAST_CODE. Since it doesn't do anything, it doesn't need to be fast. Instead we keep more `fast` RAM for other code that really benefits from being in fast RAM. There is a slight penalty to jump into slower RAM. * Gyro - Move `performGyroCalibration`out of 'fast' ram. On F7X2 it was being inlined, saved 478 bytes of ITCM. * Prevent handling of crash recovery handling, not detection of crash recovery, from being inlined to save ITCM for code that runs more frequently. FIX: Hard fault on dump of settings if no OSD selected (betaflight#12171) Add a moving home point to the osd screen with fov which shows the home position
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have potentially different HD resolutions, it's useful to display the available canvas size in the status command as per the example below when using WTFOS on DJI.
This also works with the MAX7456, so with PAL we see the following.