Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default blackbox device to NONE on reset #12221

Merged
merged 3 commits into from Jan 29, 2023

Conversation

haslinghuis
Copy link
Member

These defines seems to not used:

ENABLE_BLACKBOX_LOGGING_ON_SPIFLASH_BY_DEFAULT
ENABLE_BLACKBOX_LOGGING_ON_SDCARD_BY_DEFAULT

@haslinghuis haslinghuis added this to the 4.4 milestone Jan 19, 2023
@haslinghuis haslinghuis self-assigned this Jan 19, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Jan 20, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn requested a review from sugaarK January 23, 2023 04:48
@haslinghuis haslinghuis merged commit d926404 into betaflight:master Jan 29, 2023
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 29, 2023
@haslinghuis haslinghuis deleted the bb-init branch January 29, 2023 00:42
@hydra
Copy link
Contributor

hydra commented Jan 29, 2023

This PR incorrectly bundles USE_FLASHFS/USE_FLASH_TOOLS with FLASH chip drivers. This is incorrect. It needs to be possible to compile and use flash chips without Flash FS. Flash tools requires Flash FS.

This is especially important for #11825 where flash is used for code execution and config storage ONLY.

In the case of octospi memory mapped flash the flashfs and flash tools cannot be used as the flash tools run from memory mapped flash and you can't run code from flash and interact with (mainly writes) flash at the same time.

@hydra
Copy link
Contributor

hydra commented Jan 29, 2023

Also, as a side note the changes in target\common_post.h don't seem to have anything to do with this PR judging by the title. Was not expecting to find flash chip related changes in a PR titled: 'Default blackbox device to NONE on reset'.

@hydra
Copy link
Contributor

hydra commented Jan 30, 2023

This PR also broke the ./support/scripts/build_spracingh7extreme.sh which errorred with:

./src/main/fc/init.c: In function 'init':
./src/main/fc/init.c:379:2: error: #error "CONFIG_IN_EXTERNAL_FLASH requires USE_FLASH_CHIP to be defined."
  379 | #error "CONFIG_IN_EXTERNAL_FLASH requires USE_FLASH_CHIP to be defined."
      |  ^~~~~

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
* Default blackbox device to NONE on reset

* Add check for flashIsSupported

* Move blackbox validation outside of validateAndFixGyroConfig()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants