New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default blackbox device to NONE on reset #12221
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Do you want to test this code? Here you have an automated build: |
This PR incorrectly bundles USE_FLASHFS/USE_FLASH_TOOLS with FLASH chip drivers. This is incorrect. It needs to be possible to compile and use flash chips without Flash FS. Flash tools requires Flash FS. This is especially important for #11825 where flash is used for code execution and config storage ONLY. In the case of octospi memory mapped flash the flashfs and flash tools cannot be used as the flash tools run from memory mapped flash and you can't run code from flash and interact with (mainly writes) flash at the same time. |
Also, as a side note the changes in target\common_post.h don't seem to have anything to do with this PR judging by the title. Was not expecting to find flash chip related changes in a PR titled: 'Default blackbox device to NONE on reset'. |
This PR also broke the
|
* Default blackbox device to NONE on reset * Add check for flashIsSupported * Move blackbox validation outside of validateAndFixGyroConfig()
These defines seems to not used: