Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of QMC5883L #12243

Closed

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 27, 2023

Fixes: #12232

Retries 5 times and increased delay with 50%.

After testing it still didn't work. Interesting we found out we just need to lower I2C clockspeed to 400Hz.

@haslinghuis haslinghuis added this to the 4.4 milestone Jan 27, 2023
@haslinghuis haslinghuis self-assigned this Jan 27, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Jan 27, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

You have a complete thread with this problem: #4531
It only happens to some qmc, others work.

@haslinghuis
Copy link
Member Author

Closing now as I stumbled upon that issue after I did the PR 🙂

Finalizing Firmware 4.4 Release automation moved this from In progress to Done Jan 28, 2023
@haslinghuis haslinghuis deleted the fix-qmc5883l-detection branch January 28, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants