Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable all flash chips by default on EXST targets. #12300

Merged
merged 1 commit into from Feb 5, 2023
Merged

Don't enable all flash chips by default on EXST targets. #12300

merged 1 commit into from Feb 5, 2023

Conversation

hydra
Copy link
Contributor

@hydra hydra commented Feb 4, 2023

EXST targets generally ship with a specific flash chip, so there is no point including flash chip drivers that are never intended to be on the PCB.

e.g. there's no point including other flash chip drivers for the SPRacingH7NANO/ZERO which always have the W25N01G.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Feb 4, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

How does this work if another H7 implementation decides to use another flash chip?

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 4, 2023
@hydra
Copy link
Contributor Author

hydra commented Feb 5, 2023

How does this work if another H7 implementation decides to use another flash chip?

Not sure I fully understand your question; Any cloud build target should be able to now be built with only the flash chip drivers required for the target using the appropriate gating defines. As opposed to all the flash chip drivers which is appropriate for the large-flash, non-EXST targets like the STM32H743 target.

If a new flash chip driver is required it should be added to the list as required, and also in any target definition for EXST targets.

@blckmn
Copy link
Member

blckmn commented Feb 5, 2023

The issue I think @haslinghuis is raising is that the core build should load all flash drivers.

So that the actual detected flash can be determined.

Without me checking, I'm assuming this is outside of a cloud build.

@haslinghuis haslinghuis merged commit a19bf9b into betaflight:master Feb 5, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants