Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SD - Use SDIO by default if target uses USE_SDCARD_SDIO. #12301

Merged
merged 1 commit into from Feb 5, 2023
Merged

SD - Use SDIO by default if target uses USE_SDCARD_SDIO. #12301

merged 1 commit into from Feb 5, 2023

Conversation

hydra
Copy link
Contributor

@hydra hydra commented Feb 4, 2023

This is required when targets define USE_SDCARD_SDIO and do not define USE_SDCARD_SPI when CONFIG_IN_SD_CARD is NOT defined.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Feb 4, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 4, 2023
@hydra hydra mentioned this pull request Feb 5, 2023
Merged
@haslinghuis haslinghuis merged commit 8fd592b into betaflight:master Feb 5, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@hydra @davidbitton
SD - Use SDIO by default if target uses USE_SDCARD_SDIO. (betaflight#…
69af7a3 
…12301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@hydra hydra

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hydra @blckmn @haslinghuis @klutvott123