New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMS support on TX for ELRS #12308
Conversation
This comment has been minimized.
This comment has been minimized.
Telemetry ratio doesn't have an impact cos the telemetry rate automatically switches into 1:2 when encapsulated MSP is sent |
AUTOMERGE: (FAIL)
|
Telemetry ratio is set to 1:2 for MSP and CMS traffic, which explains why it had no impact. Now sends a CRSF ping to the RX and checks the returned device info to identify ELRS receivers and only adds DisplayPort chunk delay if necessary. |
This comment has been minimized.
This comment has been minimized.
Need to fix the unit tests… |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tested and working on MatekH743 with BetaFPV eLRS Nano RX @500hz and EdgeTX 2.8 on Jumper T-Lite Failed to work on JHEH743AIO board, flashed twice but no USB connection afterwards. Flashed master and all worked again. |
1000772
to
8ff7b02
Compare
This comment has been minimized.
This comment has been minimized.
8ff7b02
to
494a260
Compare
@SteveCEvans some builds are failing (probably fixed if we merge #12394 and rebuild |
494a260
to
5cb910c
Compare
Do you want to test this code? Here you have an automated build: |
* Never block use of SWD pins * Throttle CMS displayport traffic on CRSF to prevent ELRS overrun
This PR throttles the sending of chunks of DisplayPort data to one every 75ms to prevent overrun on ELRS telemetry channel. Tested at 1:2 to 1:128 Telem Ratios at 500Hz.
Note that this only works at 333Hz and above or D250 and above. Slow update rates don't have the telemetry bandwidth required, but surprisingly telemetry ratio has no apparent impact.
@AlessandroAU if there is a better way to apply flow control to the telemetry channel than this 75ms delay, please let me know.