Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blackboxdevice missing #12324

Merged
merged 1 commit into from Feb 10, 2023
Merged

Fix blackboxdevice missing #12324

merged 1 commit into from Feb 10, 2023
+1 −1

Conversation

haslinghuis
Copy link
Member

Fixes: #12312

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 6, 2023
@haslinghuis haslinghuis self-assigned this Feb 6, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Feb 7, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested good with make STM32F7X2_rev

@blckmn blckmn merged commit 561d0ef into betaflight:master Feb 10, 2023
@haslinghuis haslinghuis deleted the fix-blackboxdevice-missing branch February 10, 2023 21:45
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix blackboxdevice missing (betaflight#12324)
b477985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Blackbox device missing
3 participants
@haslinghuis @blckmn @nerdCopter