Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile Cleanup - further simplification of local building #12354

Merged
merged 2 commits into from Feb 14, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 12, 2023

Can now use the commands:

make BETAFLIGHTF4

make BETAFLIGHTF4_clean

make configs

Target objects for config are now kept separate, so changing a config in use will rebuild as required.

@github-actions

This comment has been minimized.

@blckmn blckmn self-assigned this Feb 12, 2023
@blckmn blckmn added this to the 4.5 milestone Feb 12, 2023
Can now use the commands:

make BETAFLIGHTF4

make BETAFLIGHTF4_clean

make configs

Target objects for config are now kept separate, so changing a config in use will rebuild as required.
@github-actions

This comment has been minimized.

@blckmn
Copy link
Member Author

blckmn commented Feb 12, 2023

Noting we could technically add "configs" to CI_TARGETS now, and we may consider some to allow for coverage of "builds".

I don't want to get to a stage where the CI takes anymore than 5 minutes to complete - this should be our policy.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member Author

blckmn commented Feb 12, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn
Copy link
Member Author

blckmn commented Feb 13, 2023

Once this is merged I'll back port for 4.4.1

@haslinghuis haslinghuis merged commit 69c779c into betaflight:master Feb 14, 2023
@blckmn blckmn deleted the make_config_patch branch February 14, 2023 18:53
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
…ht#12354)

* Makefile Cleanup - further simplification of local building

Can now use the commands:

make BETAFLIGHTF4

make BETAFLIGHTF4_clean

make configs

Target objects for config are now kept separate, so changing a config in use will rebuild as required.

* Minor correction for cummulative use in naming target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants