Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove USE_SWDIO, simply refer to DEBUG #12361

Merged
merged 1 commit into from Feb 14, 2023
Merged

Remove USE_SWDIO, simply refer to DEBUG #12361

merged 1 commit into from Feb 14, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 13, 2023 •
edited

Command line of make TARGET=STM32F405 DEBUG=GDB will trigger this.

Alternative is simply make TARGET=STM32F405 EXTRA_FLAGS="-DDEBUG"

This is if you want to use the SWDIO pins for debugging, rather than alternate functions. This is sets up for alternatives depending on MCU type, as we add more MCU options. i.e. moves some MCU specific code out of init.c

@blckmn
Remove USE_SWDIO, simply refer to debug
a226ca9 
Command line of `make TARGET=STM32F405 DEBUG=GDB` will trigger this.

Alternative is simply `make TARGET=STM32F405 EXTRA_FLAGS="-DDEBUG"`
@blckmn blckmn self-assigned this Feb 13, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member Author

blckmn commented Feb 13, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 13, 2023
@blckmn blckmn requested a review from sugaarK February 14, 2023 18:57
@haslinghuis haslinghuis merged commit 3598f3e into betaflight:master Feb 14, 2023
@blckmn blckmn deleted the swdio branch February 14, 2023 20:38
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Remove USE_SWDIO, simply refer to DEBUG (betaflight#12361)
67d5e2e 
Remove USE_SWDIO, simply refer to debug

Command line of `make TARGET=STM32F405 DEBUG=GDB` will trigger this.

Alternative is simply `make TARGET=STM32F405 EXTRA_FLAGS="-DDEBUG"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@blckmn blckmn

Labels
Ready to Merge RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blckmn @haslinghuis @klutvott123 @sugaarK