Enable SPI DMA receive before transmit on AT32 #12368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveCEvans
requested review from
blckmn,
KarateBrot,
klutvott123 and
sugaarK
This comment has been minimized.
This comment has been minimized.
haslinghuis
approved these changes
Feb 15, 2023
blckmn
approved these changes
Feb 15, 2023
klutvott123
requested changes
Feb 15, 2023
| @@ -230,8 +230,11 @@ void spiInternalStartDMA(const extDevice_t *dev) | |||
| xDMA_Cmd(streamRegsTx, TRUE); | |||
| xDMA_Cmd(streamRegsRx, TRUE); | |||
|
|
|||
| spi_i2s_dma_transmitter_enable(dev->bus->busType_u.spi.instance, TRUE); | |||
| /* Enable the receiver before the transmitter to ensure that not bits are missed on reception. An interrupt between | |||
| * the tramitter and receiver being enabled can otherwise cause a hang. | |||
klutvott123
approved these changes
Feb 15, 2023
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
* Enable DMA rx before tx * Update bus_spi_at32bsp.c Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a USB interrupt occurred between enabling the transmitter and receiver, then the first bit would be lost of reception and the SPI transfer would hang.