Fix MPU6000 reset #12371
Merged
Fix MPU6000 reset #12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Feb 15, 2023
|
AUTOMERGE: (FAIL)
|
sugaarK
approved these changes
Feb 16, 2023
blckmn
approved these changes
Feb 16, 2023
obeny
pushed a commit
to obeny/betaflight
that referenced
this pull request
Oct 11, 2023
obeny
pushed a commit
to obeny/betaflight
that referenced
this pull request
Oct 23, 2023
obeny
pushed a commit
to obeny/betaflight
that referenced
this pull request
Nov 15, 2023
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gyro detection fails on some boards after a soft reboot. This PR fixes it by restoring the reset during detection to how it used to be.
This is what the manufacturers documentation says about reset. It's also how it used to be.
Based on this I would assume that reading registers between these two operations is illegal.
It was changed last year to avoid unintentionally writing to reserved bits in the signal path reset register of the ICM20689 during gyro detection. This behaviour is preserved by moving the ICM20689 detect function to be first in the list.