Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Several build issues following configuration changes #12389

Merged
merged 3 commits into from Feb 20, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 19, 2023

  1. RX_SPI pins undefined
  2. SDCARD enabled but no utilisation (i.e. no blackbox selected).
  3. Camera Control Pin - Improved readability (readiness for "black" macro magic)

1. RX_SPI pins undefined
2. SDCARD enabled but no utilisation (i.e. no blackbox selected).
@blckmn blckmn added this to the 4.5 milestone Feb 19, 2023
@blckmn blckmn self-assigned this Feb 19, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

Makefile Show resolved Hide resolved
@blckmn
Copy link
Member Author

blckmn commented Feb 19, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 166ff9c into betaflight:master Feb 20, 2023
@blckmn blckmn deleted the build-patch-1 branch February 20, 2023 18:25
@hydra
Copy link
Contributor

hydra commented Feb 21, 2023

Since the conversation regarding adding CI_TARGETS is marked as resolved before I saw it which means others probably won't see it either, I'm re-posting my comment here:

Can we also please add to the list:

  1. SPRacingH7EXTREME to that list because it's an the only EXST H750 target that uses quad SPI and there are no other targets that check a) the EXST build system for H750 and b) that compile QuadSPI.

  2. SPRacingH7RF as it's the only EXST H730 target that uses octospi and memory mapped code as there are no other targets that check a) the EXST build system for H730 and b) that compile the OctoSPI and CONFIG_IN_MEMORY_MAPPED_FLASH code

Currently there is no CI visibility on any of the above and build or compilation issues are likely to creep in un-noticed

#endif

#if defined(USE_RX_EXPRESSLRS) && !defined(RX_EXPRESSLRS_TIMER_INSTANCE) && (defined(STM32F411) || defined(STM32F405) || defined(STM32F745) || defined(STM32H7))
#define RX_EXPRESSLRS_TIMER_INSTANCE TIM5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the corresponding targets that were relying on this been also updated to include the appropriate #define in the unified targets repo and in the src/configs folder.

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
…#12389)

* FIX: Several build issues following configuration changes

1. RX_SPI pins undefined
2. SDCARD enabled but no utilisation (i.e. no blackbox selected).

* Improved readability (readiness for "black" macro magic)

* Adding Makefile rule to enable CI targets to include Configured targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants