New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Several build issues following configuration changes #12389
Conversation
blckmn
commented
Feb 19, 2023
- RX_SPI pins undefined
- SDCARD enabled but no utilisation (i.e. no blackbox selected).
- Camera Control Pin - Improved readability (readiness for "black" macro magic)
1. RX_SPI pins undefined 2. SDCARD enabled but no utilisation (i.e. no blackbox selected).
Do you want to test this code? Here you have an automated build: |
AUTOMERGE: (FAIL)
|
Since the conversation regarding adding CI_TARGETS is marked as resolved before I saw it which means others probably won't see it either, I'm re-posting my comment here: Can we also please add to the list:
Currently there is no CI visibility on any of the above and build or compilation issues are likely to creep in un-noticed |
#endif | ||
|
||
#if defined(USE_RX_EXPRESSLRS) && !defined(RX_EXPRESSLRS_TIMER_INSTANCE) && (defined(STM32F411) || defined(STM32F405) || defined(STM32F745) || defined(STM32H7)) | ||
#define RX_EXPRESSLRS_TIMER_INSTANCE TIM5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have the corresponding targets that were relying on this been also updated to include the appropriate #define in the unified targets repo and in the src/config
s folder.
…#12389) * FIX: Several build issues following configuration changes 1. RX_SPI pins undefined 2. SDCARD enabled but no utilisation (i.e. no blackbox selected). * Improved readability (readiness for "black" macro magic) * Adding Makefile rule to enable CI targets to include Configured targets