Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW TARGET: AT32 debug targets, ATSTARTF435 and REVO-AT #12392

Merged
merged 2 commits into from Feb 21, 2023

Conversation

SteveCEvans
Copy link
Member

This PR creates config.h files for the AT-START-F435 and REVO-AT targets to aid ongoing development of AT32F4 support. Should these ever be created as unified target configs then these config.h files will be simplified to only include USE_* definitions and be generated automatically.

This PR also ensures that SWD pins are never disabled as loading a non-debug image currently prevents loading a debug without putting the device into DFU mode which isn't desirable.

@SteveCEvans SteveCEvans self-assigned this Feb 20, 2023
@github-actions

This comment has been minimized.

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 20, 2023
@blckmn
Copy link
Member

blckmn commented Feb 20, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn
Copy link
Member

blckmn commented Feb 20, 2023

@SteveCEvans partial duplicate for #12390 - but I can close that one, but there are a few ideas there you might want to grab also.

Not the AT-START-F435 directory should match the board name (i.e. remove the "-").

src/main/drivers/at32/platform_at32.h Outdated Show resolved Hide resolved
src/main/drivers/stm32/platform_stm32.h Outdated Show resolved Hide resolved
src/main/config/config_streamer.c Show resolved Hide resolved
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn mentioned this pull request Feb 20, 2023
@blckmn blckmn changed the title AT-32 debug targets, AT-START-F435 and REVO-AT AT-32 debug targets, ATSTARTF435 and REVO-AT Feb 21, 2023
@blckmn blckmn changed the title AT-32 debug targets, ATSTARTF435 and REVO-AT NEW TARGET: AT32 debug targets, ATSTARTF435 and REVO-AT Feb 21, 2023
@KarateBrot KarateBrot merged commit 1ff78c6 into betaflight:master Feb 21, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
…2392)

* Never block use of SWD pins

* Split the AT-START-F435 and REVO-AT configs out from AT32F435/target.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants