Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: moving timer definitions to MCU locations. #12397

Merged
merged 3 commits into from Feb 22, 2023
Merged

REFACTOR: moving timer definitions to MCU locations. #12397

merged 3 commits into from Feb 22, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 21, 2023

Just some re-arrangement and removing more MCU specific defines from core code base.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@blckmn blckmn self-assigned this Feb 21, 2023
@blckmn blckmn added this to the 4.5 milestone Feb 21, 2023
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Feb 21, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

haslinghuis
haslinghuis approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also restores the application of custom defaults.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@TheIsotopes TheIsotopes mentioned this pull request Feb 22, 2023
Closed
@haslinghuis haslinghuis merged commit 82566eb into betaflight:master Feb 22, 2023
@blckmn blckmn deleted the timer_patch branch February 22, 2023 22:41
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
REFACTOR: moving timer definitions to MCU locations. (betaflight#12397)
f648eb5 
* REFACTOR: moving timer definitions to MCU locations.

* Now that the MCU directory needs to be included in the search path for includes, no need for target.h entry if filenaming is consistent.

* SITL needs the empty include.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@blckmn blckmn

Labels
RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blckmn @haslinghuis @KarateBrot @klutvott123