Adding last of the settings in unified targets #12414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
haslinghuis
approved these changes
Feb 25, 2023
Will look to fix in another PR
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
blckmn
changed the title
haslinghuis
approved these changes
Feb 26, 2023
…ced). SYSTEM_HSE_MHZ now being set.
|
Do you want to test this code? Here you have an automated build: |
blckmn
requested review from
ctzsnooze,
KarateBrot,
klutvott123,
SteveCEvans and
sugaarK
|
Merged due to I2C error breaking HAL targets. |
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
* Adding GYRO and MAG alignment from settings in unified targets * I2C devices incorrectly specified, i.e. variance to how SPI is handled. * Adding in remaining setting (where a mapping is yet to be verified) * Adding check for comment in auto generation (so editing can be commenced). * SYSTEM_HSE_MHZ now being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the config files.
Goal is to stop auto generating them and only update at src/config/[targetname]/config.h.
I have added //TODO to the items that remain, so they are easily identified. Others can possibly assist in fixing some up.
None of the //TODO items will cause a board to not boot, and a backup restore would fix any non-applied items (given no custom defaults).