Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.4.1: Latest changes from unified targets, and sdcard build fix. #12415

Merged
merged 1 commit into from Feb 27, 2023
Merged

4.4.1: Latest changes from unified targets, and sdcard build fix. #12415

merged 1 commit into from Feb 27, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 24, 2023

No description provided.

@blckmn blckmn self-assigned this Feb 24, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@nerdCopter
Copy link
Member

nerdCopter commented Feb 24, 2023 •
edited

this one fixed my BETAFPVF4SX1280, TYVM
(built via cloud-build).

@haslinghuis haslinghuis added this to the 4.5 milestone Feb 24, 2023
haslinghuis
haslinghuis approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird somehow had to flash BETAFPVF4SX1280 a second time as did not communicate over VCP the first time.

Solved: BETAFPVF4SX1280, MATEKF405TE, SPEEDYBEEF7V3, KAKUTEH7MINI.
Failing: MATEKH743 (uses SDC) - no communication after flashing (with or w/o SDC inserted)
Note: Baro seems missing

@haslinghuis haslinghuis mentioned this pull request Feb 25, 2023
Closed
@ASDosjani
Copy link
Contributor

This fixed my CRAZYBEEF4SX1280, thanks.

@TheIsotopes
Copy link
Contributor

@haslinghuis why 4.5 milestone?
This PR is for 4.4-maintenance ... imho all of this is already in the 4.5 master.

@haslinghuis haslinghuis modified the milestones: 4.5, 4.4.1 Feb 25, 2023
@nerdCopter
Copy link
Member

oh wow, i missed the fact this was 4.4-maint ... 4.4 already worked for me. however, 4.5 master a few days ago, not so much. i'll have to do more testing.

@blckmn blckmn changed the title Latest changes from unified targets, and sdcard build fix. 4.4.1: Latest changes from unified targets, and sdcard build fix. Feb 25, 2023
@ASDosjani
Copy link
Contributor

I tested with BETAFPVF4SX1280 on 4.5 and it fixes master as well. Default 4.5 build is corrupted after I click on Apply custom defaults.

@blckmn blckmn merged commit 8703139 into betaflight:4.4-maintenance Feb 27, 2023
@blckmn blckmn deleted the config-patch-3 branch June 10, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@klutvott123 klutvott123 Awaiting requested review from klutvott123

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@blckmn blckmn

Labels
Ready to Merge RN: BUGFIX RN: TARGET UPDATE
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blckmn @nerdCopter @ASDosjani @TheIsotopes @haslinghuis