Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of USB drivers for AT32F4 #12441

Merged
merged 2 commits into from Mar 9, 2023
Merged

Cleanup of USB drivers for AT32F4 #12441

merged 2 commits into from Mar 9, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Mar 3, 2023

Removing USB files from drivers/at32 directory (leaving in library directory).

@github-actions

This comment has been minimized.

Sign in to view
@blckmn blckmn self-assigned this Mar 3, 2023
@blckmn blckmn added this to the 4.5 milestone Mar 3, 2023
@blckmn
Copy link
Member Author

blckmn commented Mar 3, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn mentioned this pull request Mar 8, 2023
Merged
@haslinghuis
Copy link
Member

@blckmn please rebase

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit c224c07 into betaflight:master Mar 9, 2023
18 checks passed
@blckmn blckmn deleted the at_usb branch March 9, 2023 07:14
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Cleanup of USB drivers for AT32F4 (betaflight#12441)
428a8eb 
* Cleanup of USB drivers for AT32F4
* F4 has different directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@sugaarK sugaarK sugaarK approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@blckmn blckmn

Labels
Ready to Merge RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blckmn @haslinghuis @sugaarK