Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Brushed ESC auto detect #12479

Merged
merged 1 commit into from Mar 8, 2023
Merged

Removing Brushed ESC auto detect #12479

merged 1 commit into from Mar 8, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Mar 8, 2023

  • minimise pin "activation" on init.

@blckmn
Removing Brushed ESC auto detect
e57f06e 
- minimise pin "activation" on init.
@blckmn blckmn added this to the 4.5 milestone Mar 8, 2023
@blckmn blckmn self-assigned this Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member Author

blckmn commented Mar 8, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 80e9cfb into betaflight:master Mar 8, 2023
17 checks passed
@blckmn blckmn deleted the motor-fix branch March 8, 2023 19:49
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Removing Brushed ESC auto detect (betaflight#12479)
4f3a6d9 
- minimise pin "activation" on init.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@blckmn blckmn

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blckmn @haslinghuis @KarateBrot @klutvott123