Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONFIG: Fix SDCARD CS #12488

Merged
merged 1 commit into from Mar 9, 2023
Merged

CONFIG: Fix SDCARD CS #12488

merged 1 commit into from Mar 9, 2023

Conversation

haslinghuis
Copy link
Member

Fixes: #12472

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 9, 2023
@haslinghuis haslinghuis self-assigned this Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Mar 9, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

klutvott123
klutvott123 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@klutvott123 klutvott123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Do you have a solution for 4.4 too?

@haslinghuis
Copy link
Member Author

4.4.x is using old style pin definitions.

@blckmn blckmn merged commit 035888f into betaflight:master Mar 9, 2023
@haslinghuis haslinghuis deleted the fix-sdcard branch March 9, 2023 19:36
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
CONFIG: Fix SDCARD CS (betaflight#12488)
881fb3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX RN: TARGET UPDATE
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Holybro Kakute H7 Fails to Boot with 4.4.1-zulu, and requires SD card present to boot on 4.5-zulu
3 participants
@haslinghuis @blckmn @klutvott123