Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RX protocol config #12497

Merged
merged 2 commits into from Mar 10, 2023
Merged

Fix RX protocol config #12497

merged 2 commits into from Mar 10, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 10, 2023 •
edited

No description provided.

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 10, 2023
@haslinghuis haslinghuis self-assigned this Mar 10, 2023
@github-actions

This comment has been minimized.

Sign in to view
blckmn
blckmn requested changes Mar 10, 2023
View reviewed changes
src/main/pg/rx.c Show resolved Hide resolved
src/main/target/common_defaults_post.h Outdated Show resolved Hide resolved
@blckmn
Copy link
Member

blckmn commented Mar 10, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit 33f258d into betaflight:master Mar 10, 2023
@haslinghuis haslinghuis deleted the set-defaults branch March 11, 2023 01:10
haslinghuis added a commit to haslinghuis/betaflight that referenced this pull request Mar 11, 2023
@haslinghuis
Fix RX protocol config (betaflight#12497)
29c6130 
* Fix RX protocol config
* Fixes per review
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Fix RX protocol config (betaflight#12497)
d2455fc 
* Fix RX protocol config
* Fixes per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haslinghuis @blckmn