Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 12302 NVIC SPI Priority #12505

Merged
merged 1 commit into from Mar 14, 2023

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Mar 11, 2023

This PR reverts a part of PR#12302 from Feb 6, by @hydra - the bit that changed SPI priority.

Unfortunately it seemed to badly affect some F411 boards.

For example, the NOX F411, with GPS and Softserial would randomly lock up, and fall out of the sky with 4.5. Additionally it didn't have the loop time stability I saw in the past. The only way to stop it locking up was to disable the OSD entirely.

This PR brings the old NOX board back to life, it now is rock solid stable again, even with OSD, GPS, new Angle and Horizon code. soft serial, all active.

This PR has been checked with several SX1280 ELRS SPI boards and does not appear to adversely affect link reliability.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Mar 11, 2023

Good stuff with the testing and perseverance to find this!

@ctzsnooze
Copy link
Member Author

ctzsnooze commented Mar 11, 2023

Difference in Cycletime stability - left without, right with the fix.
On right, motors were spinning and I had the new Angle/Horizon PR active. On the left, motors were not spinning, and code was just master. It locked up soon after this log.
Main benefit is that the FC doesn't lockup mid-flight now.

Screen Shot 2023-03-11 at 22 07 05

@ctzsnooze ctzsnooze removed their assignment Mar 11, 2023
@haslinghuis haslinghuis added this to the 4.5 milestone Mar 11, 2023
@ctzsnooze ctzsnooze self-assigned this Mar 11, 2023
@freasy
Copy link
Member

freasy commented Mar 11, 2023

Makes total sense to revert this! Good find!

@blckmn
Copy link
Member

blckmn commented Mar 11, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze ctzsnooze merged commit c14ef06 into betaflight:master Mar 14, 2023
@ctzsnooze ctzsnooze deleted the Revert-12302-SPI-priority branch March 23, 2023 00:51
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants