New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 12302 NVIC SPI Priority #12505
Revert 12302 NVIC SPI Priority #12505
Conversation
Do you want to test this code? Here you have an automated build: |
Good stuff with the testing and perseverance to find this! |
Difference in Cycletime stability - left without, right with the fix. |
Makes total sense to revert this! Good find! |
AUTOMERGE: (FAIL)
|
This PR reverts a part of PR#12302 from Feb 6, by @hydra - the bit that changed SPI priority.
Unfortunately it seemed to badly affect some F411 boards.
For example, the NOX F411, with GPS and Softserial would randomly lock up, and fall out of the sky with 4.5. Additionally it didn't have the loop time stability I saw in the past. The only way to stop it locking up was to disable the OSD entirely.
This PR brings the old NOX board back to life, it now is rock solid stable again, even with OSD, GPS, new Angle and Horizon code. soft serial, all active.
This PR has been checked with several SX1280 ELRS SPI boards and does not appear to adversely affect link reliability.