Exclude MSP_OSD_CONFIG if USE_OSD not defined #12513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to test this code? Here you have an automated build: |
|
@klutvott123 works great 👍 |
TheIsotopes
approved these changes
Mar 13, 2023
haslinghuis
approved these changes
Mar 13, 2023
|
AUTOMERGE: (FAIL)
|
blckmn
approved these changes
Mar 13, 2023
ctzsnooze
approved these changes
Mar 14, 2023
klutvott123
added a commit
to klutvott123/betaflight
that referenced
this pull request
Mar 28, 2023
haslinghuis
pushed a commit
that referenced
this pull request
Apr 2, 2023
davidbitton
pushed a commit
to davidbitton/betaflight
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will result in an error that can be used by clients to detect if the message is present or not. This is consistent with how it's done for MSP_SET_OSD_CONFIG. I see no reason for MSP_OSD_CONFIG to return anything that can be interpreted as valid parameters if the firmware is compiled without OSD support.